Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Taking a walk to get the git data πŸšΆβ€β™‚οΈβ€βž‘οΈ#272

Merged
potofpie merged 4 commits intomainfrom
taking-a-walk-πŸšΆβ€β™‚οΈβ€βž‘οΈ
May 5, 2025

Hidden character warning

The head ref may contain hidden characters: "taking-a-walk-\ud83d\udeb6\u200d\u2642\ufe0f\u200d\u27a1\ufe0f"
Merged

Taking a walk to get the git data πŸšΆβ€β™‚οΈβ€βž‘οΈ#272
potofpie merged 4 commits intomainfrom
taking-a-walk-πŸšΆβ€β™‚οΈβ€βž‘οΈ

Conversation

@potofpie
Copy link
Copy Markdown
Member

@potofpie potofpie commented May 5, 2025

No description provided.

@potofpie potofpie requested review from jhaynie and robindiddams May 5, 2025 17:05
Comment on lines +104 to +105
func GetGitInfoRecursive(logger logger.Logger, startDir string) (*GitInfo, error) {
dir := startDir
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to pass a max-depth to this, incase you get stuck in a sym-link loop or something

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm good point

@potofpie potofpie requested a review from robindiddams May 5, 2025 17:43
@jhaynie jhaynie requested a review from pec1985 May 5, 2025 17:57
@potofpie potofpie changed the title Takin' a walk to get the git data πŸšΆβ€β™‚οΈβ€βž‘οΈ Taking a walk to get the git data πŸšΆβ€β™‚οΈβ€βž‘οΈ May 5, 2025
@potofpie potofpie merged commit c32c5f3 into main May 5, 2025
12 checks passed
@potofpie potofpie deleted the taking-a-walk-πŸšΆβ€β™‚οΈβ€βž‘οΈ branch May 5, 2025 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants